From: Tom Tromey <tromey@redhat.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 33/348] Fix -Wsahdow warnings
Date: Tue, 22 Nov 2011 19:11:00 -0000 [thread overview]
Message-ID: <m3obw42cr8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87r51070ik.fsf@gmail.com> (Andrey Smirnov's message of "Tue, 22 Nov 2011 20:24:51 +0700")
>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:
Andrey> * breakpoint.c (update_global_location_list): Fix -Wshadow
Andrey> warnings.
Andrey> - struct breakpoint *b = loc->owner;
Andrey> + struct breakpoint *bp = loc->owner;
I think in this case it is ok to just reuse the enclosing 'b'.
That is, just delete this declaration.
'b' is just used as an iterator in this function.
Tom
next prev parent reply other threads:[~2011-11-22 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:25 Andrey Smirnov
2011-11-22 19:11 ` Tom Tromey [this message]
2011-11-28 15:13 ` [PATCH 033/238] [misc.] breakpoint.c: -Wshadow fix Andrey Smirnov
2011-12-05 11:25 ` Joel Brobecker
2011-12-05 13:05 ` Andrey Smirnov
2011-12-05 13:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3obw42cr8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox