From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26818 invoked by alias); 22 Nov 2011 19:11:59 -0000 Received: (qmail 26810 invoked by uid 22791); 22 Nov 2011 19:11:58 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 19:11:43 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAMJBfDw012644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Nov 2011 14:11:42 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAMJBfvL003558; Tue, 22 Nov 2011 14:11:41 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAMJBdvc017212; Tue, 22 Nov 2011 14:11:40 -0500 From: Tom Tromey To: Andrey Smirnov Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 33/348] Fix -Wsahdow warnings References: <87r51070ik.fsf@gmail.com> Date: Tue, 22 Nov 2011 19:11:00 -0000 In-Reply-To: <87r51070ik.fsf@gmail.com> (Andrey Smirnov's message of "Tue, 22 Nov 2011 20:24:51 +0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00601.txt.bz2 >>>>> "Andrey" == Andrey Smirnov writes: Andrey> * breakpoint.c (update_global_location_list): Fix -Wshadow Andrey> warnings. Andrey> - struct breakpoint *b = loc->owner; Andrey> + struct breakpoint *bp = loc->owner; I think in this case it is ok to just reuse the enclosing 'b'. That is, just delete this declaration. 'b' is just used as an iterator in this function. Tom