From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (take 2).
Date: Tue, 16 Jun 2009 17:32:00 -0000 [thread overview]
Message-ID: <m3my882igk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8ac60eac0906151829i496768d4pf633e13421f37b59@mail.gmail.com> (Paul Pluzhnikov's message of "Mon\, 15 Jun 2009 18\:29\:40 -0700")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> 2009-06-15 Paul Pluzhnikov <ppluzhnikov@google.com>
Paul> * solib.c (symbol_add_stub): New FLAGS parameter.
[...]
Just two nits.
Paul> +enum symfile_add_flags
Paul> + {
Paul> + SYMFILE_VERBOSE = 1 << 1,
Paul> + SYMFILE_MAINLINE = 1 << 2,
Paul> + SYMFILE_DEFER_BP_RESET = 1 << 3
Paul> + };
This needs a comment before the enum, and ideally also a comment
explaining each constant.
Paul> Index: windows-nat.c
[...]
Paul> + const int add_flags = (p->from_tty ? SYMFILE_VERBOSE : 0)
Paul> + | (p->mainline ? SYMFILE_MAINLINE : 0);
This needs parens around the whole RHS, and the continuation line
should be indented.
Ok with these changes. Thanks for persevering.
Tom
next prev parent reply other threads:[~2009-06-16 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 0:51 Paul Pluzhnikov
2009-06-15 15:18 ` Paul Pluzhnikov
2009-06-15 22:20 ` Tom Tromey
2009-06-16 1:29 ` Paul Pluzhnikov
2009-06-16 17:32 ` Tom Tromey [this message]
2009-06-16 18:51 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my882igk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox