From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64517-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18213 invoked by alias); 16 Jun 2009 17:32:21 -0000
Received: (qmail 18201 invoked by uid 22791); 16 Jun 2009 17:32:20 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Jun 2009 17:32:11 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5GHVvCZ020382; 	Tue, 16 Jun 2009 13:31:58 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5GHVubo031090; 	Tue, 16 Jun 2009 13:31:57 -0400
Received: from opsy.redhat.com (vpn-13-48.rdu.redhat.com [10.11.13.48]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5GHVuJZ020448; 	Tue, 16 Jun 2009 13:31:56 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 8F8463784BE; Tue, 16 Jun 2009 11:31:55 -0600 (MDT)
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (take  2).
References: <8ac60eac0906081750i1faddef3pe35f4983bf5ee400@mail.gmail.com> 	<m3hbyh3zrw.fsf@fleche.redhat.com> 	<8ac60eac0906151829i496768d4pf633e13421f37b59@mail.gmail.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 16 Jun 2009 17:32:00 -0000
In-Reply-To: <8ac60eac0906151829i496768d4pf633e13421f37b59@mail.gmail.com> (Paul Pluzhnikov's message of "Mon\, 15 Jun 2009 18\:29\:40 -0700")
Message-ID: <m3my882igk.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00404.txt.bz2

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> 2009-06-15  Paul Pluzhnikov  <ppluzhnikov@google.com>
Paul> 	* solib.c (symbol_add_stub): New FLAGS parameter.
 [...]

Just two nits.

Paul> +enum symfile_add_flags
Paul> +  {
Paul> +    SYMFILE_VERBOSE = 1 << 1,
Paul> +    SYMFILE_MAINLINE = 1 << 2,
Paul> +    SYMFILE_DEFER_BP_RESET = 1 << 3
Paul> +  };

This needs a comment before the enum, and ideally also a comment
explaining each constant.

Paul> Index: windows-nat.c
[...]
Paul> +  const int add_flags = (p->from_tty ? SYMFILE_VERBOSE : 0)
Paul> +      | (p->mainline ? SYMFILE_MAINLINE : 0);

This needs parens around the whole RHS, and the continuation line
should be indented.

Ok with these changes.  Thanks for persevering.

Tom