From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] GDB crash with empty executable name (MinGW)
Date: Tue, 05 Jan 2010 17:45:00 -0000 [thread overview]
Message-ID: <m3my0sa1kp.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100102124622.GW548@adacore.com> (Joel Brobecker's message of "Sat, 2 Jan 2010 16:46:22 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> 2009-01-02 Joel Brobecker <brobecker@adacore.com>
Joel> * source.c (openp): Add assert that parameter string is not NULL.
Joel> if parameter string is an empty string, then return with a failure
Joel> immediately.
Joel> Anyone in favor?
I think it would be fine, but I would recommend putting some info into
the comment explaining why this check was added... just some detail from
your original note.
Tom
next prev parent reply other threads:[~2010-01-05 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 12:47 Joel Brobecker
2010-01-02 19:34 ` Christopher Faylor
2010-01-02 21:38 ` Michael
2010-01-05 17:45 ` Tom Tromey [this message]
2010-01-08 13:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my0sa1kp.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox