From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69260-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6168 invoked by alias); 5 Jan 2010 17:45:10 -0000
Received: (qmail 5888 invoked by uid 22791); 5 Jan 2010 17:45:09 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jan 2010 17:45:04 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o05Hiftq031946 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 5 Jan 2010 12:44:41 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o05Hiept029888; 	Tue, 5 Jan 2010 12:44:40 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o05HidhS032501; 	Tue, 5 Jan 2010 12:44:39 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 0E4BA3781CA; Tue,  5 Jan 2010 10:44:39 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] GDB crash with empty executable name (MinGW)
References: <20100102124622.GW548@adacore.com>
Reply-To: tromey@redhat.com
Date: Tue, 05 Jan 2010 17:45:00 -0000
In-Reply-To: <20100102124622.GW548@adacore.com> (Joel Brobecker's message of 	"Sat, 2 Jan 2010 16:46:22 +0400")
Message-ID: <m3my0sa1kp.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00084.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> 2009-01-02  Joel Brobecker  <brobecker@adacore.com>
Joel>         * source.c (openp): Add assert that parameter string is not NULL.
Joel>         if parameter string is an empty string, then return with a failure
Joel>         immediately.

Joel> Anyone in favor?

I think it would be fine, but I would recommend putting some info into
the comment explaining why this check was added... just some detail from
your original note.

Tom