From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on NULL function's TYPE_FIELD_TYPE
Date: Tue, 30 Mar 2010 17:00:00 -0000 [thread overview]
Message-ID: <m3mxxpwxql.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100330083821.GA8227@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 30 Mar 2010 10:38:21 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> 2010-03-30 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix crash on reading wrong function declaration DWARF.
Jan> * dwarf2read.c (read_subroutine_type): New variable void_type.
Jan> Pre-fill all TYPE_FIELD_TYPEs. Move nparams and iparams initialization
Jan> more close to their use.
Jan> 2010-03-30 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> * gdb.dwarf2/dw2-bad-parameter-type.exp,
Jan> gdb.dwarf2/dw2-bad-parameter-type.S: New.
I guess this is fallout from moving the call to set_die_type earlier in
the function.
This is ok.
I'm not super happy about this change, since it seems so ad hoc. Is it
really only the field type that must be set? Or are there other things
as well? But at the same time it is hard to see what else we could do.
thanks,
Tom
next prev parent reply other threads:[~2010-03-30 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 8:38 Jan Kratochvil
2010-03-30 17:00 ` Tom Tromey [this message]
2010-03-31 18:14 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxxpwxql.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox