From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6031 invoked by alias); 30 Mar 2010 17:00:45 -0000 Received: (qmail 6016 invoked by uid 22791); 30 Mar 2010 17:00:43 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 17:00:37 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UH0ZpU007739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Mar 2010 13:00:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UH0Zgr032160; Tue, 30 Mar 2010 13:00:35 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UH0Yr3013745; Tue, 30 Mar 2010 13:00:34 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3B33037950A; Tue, 30 Mar 2010 11:00:34 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on NULL function's TYPE_FIELD_TYPE References: <20100330083821.GA8227@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 30 Mar 2010 17:00:00 -0000 In-Reply-To: <20100330083821.GA8227@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 30 Mar 2010 10:38:21 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01065.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-03-30 Jan Kratochvil Jan> Fix crash on reading wrong function declaration DWARF. Jan> * dwarf2read.c (read_subroutine_type): New variable void_type. Jan> Pre-fill all TYPE_FIELD_TYPEs. Move nparams and iparams initialization Jan> more close to their use. Jan> 2010-03-30 Jan Kratochvil Jan> * gdb.dwarf2/dw2-bad-parameter-type.exp, Jan> gdb.dwarf2/dw2-bad-parameter-type.S: New. I guess this is fallout from moving the call to set_die_type earlier in the function. This is ok. I'm not super happy about this change, since it seems so ad hoc. Is it really only the field type that must be set? Or are there other things as well? But at the same time it is hard to see what else we could do. thanks, Tom