From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PING] [RFC] Extend gdb_ari.sh with ARI_OFF/ARI_ON
Date: Fri, 21 May 2010 16:22:00 -0000 [thread overview]
Message-ID: <m3mxvt1b6x.fsf@fleche.redhat.com> (raw)
In-Reply-To: <10524.3587088355$1274389681@news.gmane.org> (Pierre Muller's message of "Thu, 20 May 2010 23:07:43 +0200")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> Noone reacted to that proposal yet...
Sorry about that.
Pierre> We this new patch, we can disable all 8 warnings of windows-nat.c
Pierre> by adding just two lines:
Pierre> /* ARI_OFF: editCase function */
Pierre> and
Pierre> /* ARI_ON: editCase function */
Pierre> at the start and the end of the list of
Pierre> bad_MixedFunctionNameSameAsWindowsAPI
Pierre> list.
Pierre> Comments?
I think this kind of mechanism is too obscure. The markers may be very
far from the place that one is editing.
Do we really need this particular ARI rule at all? This sort of problem
is usually caught by patch review... and if it an instance is missed, it
doesn't have any impact on code quality.
Tom
next parent reply other threads:[~2010-05-21 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <10524.3587088355$1274389681@news.gmane.org>
2010-05-21 16:22 ` Tom Tromey [this message]
2010-05-21 16:25 ` Pierre Muller
[not found] ` <37953.9021793336$1274458961@news.gmane.org>
2010-05-21 16:52 ` Tom Tromey
2010-05-20 21:13 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxvt1b6x.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox