From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2378 invoked by alias); 21 May 2010 16:17:49 -0000 Received: (qmail 2364 invoked by uid 22791); 21 May 2010 16:17:46 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 May 2010 16:17:34 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4LGHSbl019845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 May 2010 12:17:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4LGHRC8010357; Fri, 21 May 2010 12:17:28 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4LGHQe1030708; Fri, 21 May 2010 12:17:27 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4E09E37818E; Fri, 21 May 2010 10:17:26 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [PING] [RFC] Extend gdb_ari.sh with ARI_OFF/ARI_ON References: <10524.3587088355$1274389681@news.gmane.org> Reply-To: tromey@redhat.com Date: Fri, 21 May 2010 16:22:00 -0000 In-Reply-To: <10524.3587088355$1274389681@news.gmane.org> (Pierre Muller's message of "Thu, 20 May 2010 23:07:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00497.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> Noone reacted to that proposal yet... Sorry about that. Pierre> We this new patch, we can disable all 8 warnings of windows-nat.c Pierre> by adding just two lines: Pierre> /* ARI_OFF: editCase function */ Pierre> and Pierre> /* ARI_ON: editCase function */ Pierre> at the start and the end of the list of Pierre> bad_MixedFunctionNameSameAsWindowsAPI Pierre> list. Pierre> Comments? I think this kind of mechanism is too obscure. The markers may be very far from the place that one is editing. Do we really need this particular ARI rule at all? This sort of problem is usually caught by patch review... and if it an instance is missed, it doesn't have any impact on code quality. Tom