Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: Taisuke Yamada <tai@rakugaki.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] sys.argv and ipython (interactive python) support in GDB/Python
Date: Fri, 01 Jul 2011 14:34:00 -0000	[thread overview]
Message-ID: <m3mxgycbnw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3ei2a467u.fsf@redhat.com> (Phil Muldoon's message of "Fri, 01	Jul 2011 11:59:17 +0100")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I should know this, but the documentation notes "New in version
Phil> 2.6.6".  I think we support 2.6.6, but one of the maintainers would have
Phil> to reply here.

Thanks, I missed this.

We support back to 2.4.  So, we can't use this function unconditionally.

Perhaps we can instead call PySys_SetArgv followed by popping sys.path,
as recommended in the manual.

Phil> Lastly, even though this patch is about two lines, I believe it is
Phil> not a trivial change, and probably needs a ChangeLog entry.

I think it is trivial for copyright purposes.
All patches require a ChangeLog entry.

Tom


  parent reply	other threads:[~2011-07-01 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  4:00 Taisuke Yamada
     [not found] ` <BANLkTimcWKLMOkd0R8bNT-z4yqr0FJ_uog@mail.gmail.com>
2011-07-01 10:31   ` Kevin Pouget
2011-07-01 10:59 ` Phil Muldoon
2011-07-01 14:10   ` Taisuke Yamada
2011-07-01 14:14     ` Phil Muldoon
2011-07-01 14:34   ` Tom Tromey [this message]
2011-07-01 14:27 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mxgycbnw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=tai@rakugaki.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox