From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16137 invoked by alias); 1 Jul 2011 14:34:46 -0000 Received: (qmail 16128 invoked by uid 22791); 1 Jul 2011 14:34:46 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_RG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jul 2011 14:34:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p61EYUgM001235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jul 2011 10:34:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p61EYTZL024425; Fri, 1 Jul 2011 10:34:29 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p61EYRp5023992; Fri, 1 Jul 2011 10:34:28 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: Taisuke Yamada , gdb-patches@sourceware.org Subject: Re: [PATCH] sys.argv and ipython (interactive python) support in GDB/Python References: Date: Fri, 01 Jul 2011 14:34:00 -0000 In-Reply-To: (Phil Muldoon's message of "Fri, 01 Jul 2011 11:59:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00018.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> I should know this, but the documentation notes "New in version Phil> 2.6.6". I think we support 2.6.6, but one of the maintainers would have Phil> to reply here. Thanks, I missed this. We support back to 2.4. So, we can't use this function unconditionally. Perhaps we can instead call PySys_SetArgv followed by popping sys.path, as recommended in the manual. Phil> Lastly, even though this patch is about two lines, I believe it is Phil> not a trivial change, and probably needs a ChangeLog entry. I think it is trivial for copyright purposes. All patches require a ChangeLog entry. Tom