From: Tom Tromey <tromey@redhat.com>
To: matt rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] issues in bcache_xmalloc calls.
Date: Fri, 26 Aug 2011 16:56:00 -0000 [thread overview]
Message-ID: <m3mxewt8m9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1314350550-15312-1-git-send-email-ratmice@gmail.com> (matt rice's message of "Fri, 26 Aug 2011 02:22:30 -0700")
>>>>> "matt" == matt rice <ratmice@gmail.com> writes:
matt> 2011-08-26 Matt Rice <ratmice@gmail.com>
matt> * solib-sunos.c (allocate_rt_common_objfile): Add missing arguments to
matt> bcache_xmalloc.
matt> * symfile.c (reread_symbols): Remove extra calls to bcache_xmalloc.
Thanks.
matt> + objfile->psymbol_cache = bcache_xmalloc (NULL, NULL);
This one should call psymbol_bcache_init.
The patch is ok with this change.
Not your problem, but I think it is bogus that solib-sunos.c allocates
an objfile on its own like this. This sort of thing should be in
objfiles.c, because the current approach makes it too easy to miss this
code when making changes to objfile.
Tom
next prev parent reply other threads:[~2011-08-26 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:23 matt rice
2011-08-26 12:06 ` Pedro Alves
2011-08-26 16:56 ` Tom Tromey [this message]
2011-08-27 10:38 ` Matt Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxewt8m9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox