From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 511 invoked by alias); 26 Aug 2011 16:56:18 -0000 Received: (qmail 499 invoked by uid 22791); 26 Aug 2011 16:56:16 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 16:56:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QGu0JS030548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Aug 2011 12:56:00 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7QGtxgR002221; Fri, 26 Aug 2011 12:55:59 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7QGtw3J005261; Fri, 26 Aug 2011 12:55:58 -0400 From: Tom Tromey To: matt rice Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] issues in bcache_xmalloc calls. References: <1314350550-15312-1-git-send-email-ratmice@gmail.com> Date: Fri, 26 Aug 2011 16:56:00 -0000 In-Reply-To: <1314350550-15312-1-git-send-email-ratmice@gmail.com> (matt rice's message of "Fri, 26 Aug 2011 02:22:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00497.txt.bz2 >>>>> "matt" == matt rice writes: matt> 2011-08-26 Matt Rice matt> * solib-sunos.c (allocate_rt_common_objfile): Add missing arguments to matt> bcache_xmalloc. matt> * symfile.c (reread_symbols): Remove extra calls to bcache_xmalloc. Thanks. matt> + objfile->psymbol_cache = bcache_xmalloc (NULL, NULL); This one should call psymbol_bcache_init. The patch is ok with this change. Not your problem, but I think it is bogus that solib-sunos.c allocates an objfile on its own like this. This sort of thing should be in objfiles.c, because the current approach makes it too easy to miss this code when making changes to objfile. Tom