From: Jim Blandy <jimb@codesourcery.com>
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Cc: GDB Patches Mailing List <gdb-patches@sourceware.org>
Subject: Re: [patch] Add support for PPC Altivec registers in core files
Date: Tue, 23 Oct 2007 15:48:00 -0000 [thread overview]
Message-ID: <m3lk9t6f8y.fsf@codesourcery.com> (raw)
In-Reply-To: <471CE30E.9040705@linux.vnet.ibm.com> (Carlos Eduardo Seo's message of "Mon, 22 Oct 2007 15:51:10 -0200")
Carlos Eduardo Seo <cseo at linux.vnet.ibm.com> writes:
> Carlos Eduardo Seo
> Software Engineer
> IBM Linux Technology Center
> 2007-10-22 Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
>
> * ppc-linux-tdep.c (ppc32_linux_reg_offsets): Corrected
> swapped offsets and VRSAVE offset.
> (ppc64_linux_reg_offsets): Corrected swapped offsets.
> (ppc32_linux_vrregset): Added. Necessary for reading the
> Altivec registers from the core file.
I can't approve this, but I can pick nits. :)
The best place to explain why ppc32_linux_vrregset is necessary is in
a comment above the definition in the code, not in the ChangeLog file.
next prev parent reply other threads:[~2007-10-23 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 18:08 Carlos Eduardo Seo
2007-10-23 15:48 ` Jim Blandy [this message]
2007-10-23 20:09 ` Carlos Eduardo Seo
2007-10-26 0:04 ` Carlos Eduardo Seo
2007-10-26 0:13 ` Ulrich Weigand
2007-10-26 14:52 ` Carlos Eduardo Seo
2007-10-26 15:23 ` Ulrich Weigand
2007-10-26 15:29 ` Carlos Eduardo Seo
2007-10-29 19:02 ` Ulrich Weigand
2007-10-29 20:31 ` Carlos Eduardo Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lk9t6f8y.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=cseo@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox