From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13313 invoked by alias); 23 Oct 2007 15:08:14 -0000 Received: (qmail 13303 invoked by uid 22791); 23 Oct 2007 15:08:14 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 23 Oct 2007 15:08:11 +0000 Received: (qmail 2314 invoked from network); 23 Oct 2007 15:08:00 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Oct 2007 15:08:00 -0000 To: Carlos Eduardo Seo Cc: GDB Patches Mailing List Subject: Re: [patch] Add support for PPC Altivec registers in core files References: <471CE30E.9040705@linux.vnet.ibm.com> From: Jim Blandy Date: Tue, 23 Oct 2007 15:48:00 -0000 In-Reply-To: <471CE30E.9040705@linux.vnet.ibm.com> (Carlos Eduardo Seo's message of "Mon, 22 Oct 2007 15:51:10 -0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00539.txt.bz2 Carlos Eduardo Seo writes: > Carlos Eduardo Seo > Software Engineer > IBM Linux Technology Center > 2007-10-22 Carlos Eduardo Seo > > * ppc-linux-tdep.c (ppc32_linux_reg_offsets): Corrected > swapped offsets and VRSAVE offset. > (ppc64_linux_reg_offsets): Corrected swapped offsets. > (ppc32_linux_vrregset): Added. Necessary for reading the > Altivec registers from the core file. I can't approve this, but I can pick nits. :) The best place to explain why ppc32_linux_vrregset is necessary is in a comment above the definition in the code, not in the ChangeLog file.