From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] cleanup stale exec.{h|c} xfer_memory comments.
Date: Tue, 23 Jun 2009 20:54:00 -0000 [thread overview]
Message-ID: <m3ljnik70o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4A4133F9.3070208@codesourcery.com> (Stan Shebs's message of "Tue\, 23 Jun 2009 12\:58\:49 -0700")
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> I think that in many cases functions in a header don't get
Stan> documentation there because they are intended to be semi-private, and
Stan> are only in a header because of the rules of C and our own
Stan> conventions. For such functions it would at least be useful to have a
Stan> line "semi-private, don't assume you can use this for your own
Stan> purposes".
Yeah. My ideal in these cases is to have a second header which is
private to the implementation.
Stan> Should we maybe introduce a coding rule requiring at least a brief
Stan> API/usage comment about each function declaration in a header? Perhaps
Stan> all the semi-private functions can be separated into a block with a
Stan> comment that applies to the lot of them.
It would be fine by me, for public APIs. For existing messy headers,
I don't care so much (unless someone wants to do some big cleanups on
them), but I would like it if new headers were to be written to a
Blandyesque standard.
Tom
next prev parent reply other threads:[~2009-06-23 20:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 18:41 Pedro Alves
2009-06-13 3:47 ` Eli Zaretskii
2009-06-13 11:12 ` Joel Brobecker
2009-06-15 18:31 ` Tom Tromey
2009-06-16 0:20 ` Joel Brobecker
2009-06-23 19:59 ` Stan Shebs
2009-06-23 20:54 ` Tom Tromey [this message]
2009-06-13 11:48 ` Pedro Alves
2009-06-13 12:24 ` Eli Zaretskii
2009-06-13 13:26 ` Pedro Alves
2009-06-13 13:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljnik70o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox