Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] cleanup stale exec.{h|c} xfer_memory comments.
Date: Sat, 13 Jun 2009 12:24:00 -0000	[thread overview]
Message-ID: <E1MFSHw-0001f4-CY@fencepost.gnu.org> (raw)
In-Reply-To: <200906131250.02973.pedro@codesourcery.com> (message from Pedro 	Alves on Sat, 13 Jun 2009 12:50:02 +0100)

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sat, 13 Jun 2009 12:50:02 +0100
> Cc: gdb-patches@sourceware.org
> 
> The other exported functions of exec.c were
> described in the header (and the ones that are new came from
> target.h, that describes many function in the header too, including
> the ones related to section_table_xfer_memory_partial).  I thought
> I'd follow suit for consistency with the surrounding code.

I didn't know that exec.c describes functions in the headers.  I'm
traveling and have no easy access to GDB sources.  I just saw that you
removed the description from exec.c and added the more accurate one to
exec.h.

> > That's reasonable 
> > for data structures, but we have a lot of functions documented right
> > before their source, not in the headers.  I find the documentation in
> > the .c files easier to use, because you don't need to consult another
> > file.  
> 
> Fine with me.  But if we're going to move the description of
> this function, we should move all the others in exec.h too.  Shall
> I do this, or do you want to do it?

I will be able to do that only  in a few days, when I return home.  So
if you have time before that, please do it.  Or maybe we should wait
for others to chime in: this is a matter of personal preferences, and
I've been burned before asking to adhere to mine.

> > This is C, not C++, so the interface and the implementation are 
> > not separated.
> 
> I must not understand header files then.  (I've no idea why C++
> is being referenced here.)

Forget it.


  reply	other threads:[~2009-06-13 12:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 18:41 Pedro Alves
2009-06-13  3:47 ` Eli Zaretskii
2009-06-13 11:12   ` Joel Brobecker
2009-06-15 18:31     ` Tom Tromey
2009-06-16  0:20       ` Joel Brobecker
2009-06-23 19:59       ` Stan Shebs
2009-06-23 20:54         ` Tom Tromey
2009-06-13 11:48   ` Pedro Alves
2009-06-13 12:24     ` Eli Zaretskii [this message]
2009-06-13 13:26       ` Pedro Alves
2009-06-13 13:31         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1MFSHw-0001f4-CY@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox