Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Peter O'Gorman" <gdb-patches@mlists.thewrittenword.com>
Cc: gdb-patches@sourceware.org
Subject: Re: minor portability patches
Date: Tue, 21 Sep 2010 20:06:00 -0000	[thread overview]
Message-ID: <m3lj6veyzv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100921164814.GC32745@tw.local> (Peter O'Gorman's message of	"Tue, 21 Sep 2010 11:48:16 -0500")

>>>>> "Peter" == Peter O'Gorman <gdb-patches@mlists.thewrittenword.com> writes:

Peter> We just built gdb-7.2 and had a couple of minor issues.
Peter> Patches attached, some I am less sure about than others.

Thanks.

The patches need ChangeLog entries.

Peter> When we build --with-python, IRIX 6.5 needed -lpthread, I don't know if
Peter> this is the correct place to add that though.

Me neither.  I'm not sure how we handle static linking against python,
or whether we even support it.

Peter> __FUNCTION__ is a gccism.

BFD patches should go to the binutils list.

Peter> At least solaris cc complained about returning from void functions.

This one and the cplus_struct_default patch are obvious once you have a
ChangeLog entry.

GCC's -Wreturn-type is supposed to complain about this (the void
function thing), at least according to my reading of the docs, but it
doesn't.

Tom


  reply	other threads:[~2010-09-21 18:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 19:59 Peter O'Gorman
2010-09-21 20:06 ` Tom Tromey [this message]
2010-09-21 20:40   ` Joel Brobecker
2010-09-21 20:50     ` Peter O'Gorman
2010-09-21 21:56       ` Joel Brobecker
2010-09-21 21:09   ` Peter O'Gorman
2010-09-22 16:15   ` Doug Evans
2010-09-23 22:03 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lj6veyzv.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@mlists.thewrittenword.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox