From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26726 invoked by alias); 21 Sep 2010 18:24:32 -0000 Received: (qmail 26717 invoked by uid 22791); 21 Sep 2010 18:24:31 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Sep 2010 18:24:26 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8LIOMTp019472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 Sep 2010 14:24:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8LIOLQ8013796; Tue, 21 Sep 2010 14:24:21 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8LIOKq0001864; Tue, 21 Sep 2010 14:24:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 64993378875; Tue, 21 Sep 2010 12:24:20 -0600 (MDT) From: Tom Tromey To: "Peter O'Gorman" Cc: gdb-patches@sourceware.org Subject: Re: minor portability patches References: <20100921164814.GC32745@tw.local> Date: Tue, 21 Sep 2010 20:06:00 -0000 In-Reply-To: <20100921164814.GC32745@tw.local> (Peter O'Gorman's message of "Tue, 21 Sep 2010 11:48:16 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00351.txt.bz2 >>>>> "Peter" == Peter O'Gorman writes: Peter> We just built gdb-7.2 and had a couple of minor issues. Peter> Patches attached, some I am less sure about than others. Thanks. The patches need ChangeLog entries. Peter> When we build --with-python, IRIX 6.5 needed -lpthread, I don't know if Peter> this is the correct place to add that though. Me neither. I'm not sure how we handle static linking against python, or whether we even support it. Peter> __FUNCTION__ is a gccism. BFD patches should go to the binutils list. Peter> At least solaris cc complained about returning from void functions. This one and the cplus_struct_default patch are obvious once you have a ChangeLog entry. GCC's -Wreturn-type is supposed to complain about this (the void function thing), at least according to my reading of the docs, but it doesn't. Tom