From: Tom Tromey <tromey@redhat.com>
To: "Baars\, M.J." <mjbaars1977.gdb@gmail.com>
Cc: gdb@sourceware.org, gdb-patches@sourceware.org,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: print_npx_status_word
Date: Mon, 18 Apr 2011 17:04:00 -0000 [thread overview]
Message-ID: <m3liz78pak.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com> (M. J. Baars's message of "Sat, 16 Apr 2011 15:46:09 +0200")
>>>>> "Michael" == Baars, M J <mjbaars1977.gdb@gmail.com> writes:
Michael> Oops... did I remove one of your entries in the ChangeLog? :)
As others have noted, ChangeLog is "prepend only".
We generally don't edit old entries.
Michael> +struct
Michael> +{
Michael> + char *tag;
Michael> + char *description;
Michael> +}
Wrong indentation here, should be 2 spaces.
Fields should have descriptive comments.
I think the struct should have a tag and be terminated here.
Also the fields should be "const".
Michael> +static const npx_exception_flags[6] =
Michael> +
Michael> +{
Michael> + {"IE", "invalid operation"},
Wrong indentation. This is a problem in the whole patch.
Michael> +// print the numeric coprocessor extension (npx) status word
No `//' comments.
Comments should be full sentences, see GNU standards.
Michael> +void print_npx_status_word(uint16_t npx_status_word, struct ui_file *file)
Newline after "void".
Space before "(" -- a problem in a few spots.
Again, GNU standards.
Tom
next prev parent reply other threads:[~2011-04-18 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DA7166F.10302@gmail.com>
[not found] ` <m3aafshl6l.fsf@fleche.redhat.com>
[not found] ` <4DA7ED79.3000400@gmail.com>
[not found] ` <m3ei53efd8.fsf@fleche.redhat.com>
[not found] ` <4DA87235.7060003@gmail.com>
[not found] ` <m3pqoncw78.fsf@fleche.redhat.com>
[not found] ` <4DA87479.50203@gmail.com>
[not found] ` <m3lizbcvt7.fsf@fleche.redhat.com>
2011-04-16 6:09 ` print_npx_status_word Baars, M.J.
2011-04-16 8:24 ` print_npx_status_word Mark Kettenis
2011-04-16 13:46 ` print_npx_status_word Baars, M.J.
2011-04-16 14:29 ` print_npx_status_word Daniel Jacobowitz
2011-04-16 16:21 ` print_npx_status_word Baars, M.J.
2011-04-16 16:33 ` print_npx_status_word Mark Kettenis
2011-04-16 16:47 ` print_npx_status_word Baars, M.J.
2011-04-16 17:10 ` print_npx_status_word Mark Kettenis
2011-04-16 17:55 ` print_npx_status_word Baars, M.J.
2011-04-16 18:07 ` print_npx_status_word Marek Polacek
2011-04-18 17:00 ` print_npx_status_word Tom Tromey
2011-04-16 16:45 ` print_npx_status_word Eli Zaretskii
[not found] ` <4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com>
2011-04-18 17:04 ` Tom Tromey [this message]
2011-04-19 19:01 ` print_npx_status_word Baars, M.J.
2011-04-19 19:53 ` print_npx_status_word Pedro Alves
2011-04-19 20:11 ` print_npx_status_word Tom Tromey
2011-04-18 17:04 ` print_npx_status_word Tom Tromey
2011-04-14 16:17 print_npx_status_word Baars, M.J.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3liz78pak.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=mjbaars1977.gdb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox