From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80398-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20248 invoked by alias); 18 Apr 2011 17:04:04 -0000
Received: (qmail 20230 invoked by uid 22791); 18 Apr 2011 17:04:03 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Apr 2011 17:03:50 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3IH3nj1029734	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 18 Apr 2011 13:03:49 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3IH3msw026525;	Mon, 18 Apr 2011 13:03:48 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3IH3l39013235;	Mon, 18 Apr 2011 13:03:48 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 8752B37930B; Mon, 18 Apr 2011 11:03:47 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Baars\, M.J." <mjbaars1977.gdb@gmail.com>
Cc: gdb@sourceware.org, gdb-patches@sourceware.org,        Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: print_npx_status_word
References: <4DA7166F.10302@gmail.com> <m3aafshl6l.fsf@fleche.redhat.com>	<4DA7ED79.3000400@gmail.com> <m3ei53efd8.fsf@fleche.redhat.com>	<4DA87235.7060003@gmail.com> <m3pqoncw78.fsf@fleche.redhat.com>	<4DA87479.50203@gmail.com> <m3lizbcvt7.fsf@fleche.redhat.com>	<4DA93270.6030708@gmail.com>	<201104160824.p3G8ONWV006175@glazunov.sibelius.xs4all.nl>	<4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com>
Date: Mon, 18 Apr 2011 17:04:00 -0000
In-Reply-To: <4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com>	(M. J. Baars's message of "Sat, 16 Apr 2011 15:46:09 +0200")
Message-ID: <m3liz78pak.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00280.txt.bz2

>>>>> "Michael" == Baars, M J <mjbaars1977.gdb@gmail.com> writes:

Michael> Oops... did I remove one of your entries in the ChangeLog? :)

As others have noted, ChangeLog is "prepend only".
We generally don't edit old entries.

Michael> +struct
Michael> +{
Michael> +	char *tag;
Michael> +	char *description;
Michael> +}

Wrong indentation here, should be 2 spaces.
Fields should have descriptive comments.
I think the struct should have a tag and be terminated here.
Also the fields should be "const".

Michael> +static const npx_exception_flags[6] =
Michael> +
Michael> +{
Michael> +	{"IE", "invalid operation"},

Wrong indentation.  This is a problem in the whole patch.

Michael> +// print the numeric coprocessor extension (npx) status word

No `//' comments.
Comments should be full sentences, see GNU standards.

Michael> +void print_npx_status_word(uint16_t npx_status_word, struct ui_file *file)

Newline after "void".
Space before "(" -- a problem in a few spots.
Again, GNU standards.

Tom