Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] gdb crash in cp_scan_for_anonymous_namespace
Date: Thu, 20 Oct 2011 19:49:00 -0000	[thread overview]
Message-ID: <m3k47zmooa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <j7ps1q$c1k$1@dough.gmane.org> (Aleksandar Ristovski's message of	"Thu, 20 Oct 2011 15:16:06 -0400")

>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:

Aleksandar> I haven't created a testcase yet (the case I have is quite
Aleksandar> complicated with numerous shared objects involved and a
Aleksandar> core).

I think your change is clearly correct, given the comment before
symbol::symtab:

  /* The symbol table containing this symbol.  This is the file
     associated with LINE.  It can be NULL during symbols read-in but it is
     never NULL during normal operation.  */

Aleksandar> 2011-10-20  Aleksandar Ristovski  <aristovski@qnx.com>
Aleksandar>         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Changed
Aleksandar> function
Aleksandar>         arguments by adding OBJFILE.  Instead of getting objfile from
Aleksandar>         symbol's symtab, use new argument OBJFILE.
Aleksandar>         * cp-support.h (cp_scan_for_anonymous_namespaces): Changed function
Aleksandar>         arguments by adding OBJFILE.
Aleksandar>         * gdb/dwarf2read.c (new_symbol_full): Change call to
Aleksandar>         cp_scan_for_anonymous_namespaces to match new signature.
Aleksandar>         * gdb/stabsread.c (define_symbol): Change call to
Aleksandar>         cp_scan_for_anonymous_namespaces to match new signature.

Ok.

Tom


  reply	other threads:[~2011-10-20 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 19:33 Aleksandar Ristovski
2011-10-20 19:49 ` Tom Tromey [this message]
2011-10-20 20:18   ` Aleksandar Ristovski
2011-10-20 20:41     ` Aleksandar Ristovski
2011-10-20 22:09       ` Tom Tromey
2011-10-25 18:35         ` Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k47zmooa.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=aristovski@qnx.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox