From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16911 invoked by alias); 20 Oct 2011 19:46:52 -0000 Received: (qmail 16902 invoked by uid 22791); 20 Oct 2011 19:46:51 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=AWL,BAYES_05,KAM_STOCKTIP,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 19:46:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9KJkVx1020840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Oct 2011 15:46:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9KJkVTW029000; Thu, 20 Oct 2011 15:46:31 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9KJkTK0008593; Thu, 20 Oct 2011 15:46:30 -0400 From: Tom Tromey To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] gdb crash in cp_scan_for_anonymous_namespace References: Date: Thu, 20 Oct 2011 19:49:00 -0000 In-Reply-To: (Aleksandar Ristovski's message of "Thu, 20 Oct 2011 15:16:06 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00573.txt.bz2 >>>>> "Aleksandar" == Aleksandar Ristovski writes: Aleksandar> I haven't created a testcase yet (the case I have is quite Aleksandar> complicated with numerous shared objects involved and a Aleksandar> core). I think your change is clearly correct, given the comment before symbol::symtab: /* The symbol table containing this symbol. This is the file associated with LINE. It can be NULL during symbols read-in but it is never NULL during normal operation. */ Aleksandar> 2011-10-20 Aleksandar Ristovski Aleksandar> * cp-namespace.c (cp_scan_for_anonymous_namespaces): Changed Aleksandar> function Aleksandar> arguments by adding OBJFILE. Instead of getting objfile from Aleksandar> symbol's symtab, use new argument OBJFILE. Aleksandar> * cp-support.h (cp_scan_for_anonymous_namespaces): Changed function Aleksandar> arguments by adding OBJFILE. Aleksandar> * gdb/dwarf2read.c (new_symbol_full): Change call to Aleksandar> cp_scan_for_anonymous_namespaces to match new signature. Aleksandar> * gdb/stabsread.c (define_symbol): Change call to Aleksandar> cp_scan_for_anonymous_namespaces to match new signature. Ok. Tom