From: Jim Blandy <jimb@codesourcery.com>
To: msnyder@sonic.net
Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [OB] tui, coding standard
Date: Wed, 15 Aug 2007 21:47:00 -0000 [thread overview]
Message-ID: <m3ir7g1ncz.fsf@codesourcery.com> (raw)
In-Reply-To: <20463.12.7.175.2.1187211104.squirrel@webmail.sonic.net> (msnyder@sonic.net's message of "Wed, 15 Aug 2007 13:51:44 -0700 (PDT)")
msnyder@sonic.net writes:
>>> Date: Tue, 14 Aug 2007 17:18:45 -0700 (PDT)
>>> From: msnyder@sonic.net
>>>
>>> && and || operators.
>>
>> This diff wraps some lines that fit perfectly well on a single line; I
>> think you shouldn't do that. Otherwise, this looks ok.
>
> OK, maybe I was a little gung ho. Do you have an idea,
> for yourself, of what constitutes a line that is too long?
You didn't ask me, :) but my rule is that a &&-chain or a ||-chain
should either fit entirely on one line, or have one condition per
line. Either horizontal or vertical, but not a mix.
I sure wouldn't want to require every && or || to be on its own line,
but I don't like to read mixes, ergo...
prev parent reply other threads:[~2007-08-15 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 0:19 msnyder
2007-08-15 6:52 ` Mark Kettenis
2007-08-15 20:52 ` msnyder
2007-08-15 21:47 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ir7g1ncz.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox