From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50349-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17917 invoked by alias); 15 Aug 2007 21:47:45 -0000
Received: (qmail 17707 invoked by uid 22791); 15 Aug 2007 21:47:44 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Aug 2007 21:47:42 +0000
Received: (qmail 7973 invoked from network); 15 Aug 2007 21:47:41 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 15 Aug 2007 21:47:41 -0000
To: msnyder@sonic.net
Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>,  gdb-patches@sourceware.org
Subject: Re: [OB] tui, coding standard
References: <22565.12.7.175.2.1187137125.squirrel@webmail.sonic.net> 	<200708150652.l7F6qPEL009472@brahms.sibelius.xs4all.nl> 	<20463.12.7.175.2.1187211104.squirrel@webmail.sonic.net>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 15 Aug 2007 21:47:00 -0000
In-Reply-To: <20463.12.7.175.2.1187211104.squirrel@webmail.sonic.net> (msnyder@sonic.net's message of "Wed, 15 Aug 2007 13:51:44 -0700 (PDT)")
Message-ID: <m3ir7g1ncz.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00322.txt.bz2


msnyder@sonic.net writes:
>>> Date: Tue, 14 Aug 2007 17:18:45 -0700 (PDT)
>>> From: msnyder@sonic.net
>>>
>>> && and || operators.
>>
>> This diff wraps some lines that fit perfectly well on a single line; I
>> think you shouldn't do that.  Otherwise, this looks ok.
>
> OK, maybe I was a little gung ho.  Do you have an idea,
> for yourself, of what constitutes a line that is too long?

You didn't ask me, :) but my rule is that a &&-chain or a ||-chain
should either fit entirely on one line, or have one condition per
line.  Either horizontal or vertical, but not a mix.

I sure wouldn't want to require every && or || to be on its own line,
but I don't like to read mixes, ergo...