Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Remove 'run cleanup chain'
Date: Wed, 14 Nov 2007 22:44:00 -0000	[thread overview]
Message-ID: <m3ir445txm.fsf@codesourcery.com> (raw)
In-Reply-To: <200711141553.54912.vladimir@codesourcery.com> (Vladimir Prus's message of "Wed, 14 Nov 2007 15:53:54 +0300")


Vladimir Prus <vladimir at codesourcery.com> writes:
> GDB now has a special 'run cleanup chain', but it seems to
> be not really needed.
>
> This cleanup chain is only used to call clear_solib in response
> to 'run' command. However:
>    - Just calling clear_solib is much simpler
>    - We need to call clear_solib for attach, too, and it's done
>    via direct call, so it's better to have run be similar to
>    attach.
>
> There's comment in jv-lang.c that hints that the run cleanup can
> be useful, but is broken, and the code containing the
> comment is not actually used itself.
>
> So, it seems to me that carrying this general code for the
> sake of a single client that is only complicated as result is not good,
> here's a patch to remove run cleanup chain. OK?

This needs a ChangeLog entry.  :)


  reply	other threads:[~2007-11-14 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14 12:54 Vladimir Prus
2007-11-14 22:44 ` Jim Blandy [this message]
2007-11-15  6:25   ` Vladimir Prus
2007-11-15  7:05     ` Markus Deuling
2007-11-15  7:12       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ir445txm.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox