From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52194-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20064 invoked by alias); 14 Nov 2007 22:44:10 -0000
Received: (qmail 20045 invoked by uid 22791); 14 Nov 2007 22:44:09 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 22:44:07 +0000
Received: (qmail 28637 invoked from network); 14 Nov 2007 22:44:05 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 14 Nov 2007 22:44:05 -0000
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Remove 'run cleanup chain'
References: <200711141553.54912.vladimir@codesourcery.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 14 Nov 2007 22:44:00 -0000
In-Reply-To: <200711141553.54912.vladimir@codesourcery.com> (Vladimir Prus's message of "Wed, 14 Nov 2007 15:53:54 +0300")
Message-ID: <m3ir445txm.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-11/txt/msg00290.txt.bz2


Vladimir Prus <vladimir at codesourcery.com> writes:
> GDB now has a special 'run cleanup chain', but it seems to
> be not really needed.
>
> This cleanup chain is only used to call clear_solib in response
> to 'run' command. However:
>    - Just calling clear_solib is much simpler
>    - We need to call clear_solib for attach, too, and it's done
>    via direct call, so it's better to have run be similar to
>    attach.
>
> There's comment in jv-lang.c that hints that the run cleanup can
> be useful, but is broken, and the code containing the
> comment is not actually used itself.
>
> So, it seems to me that carrying this general code for the
> sake of a single client that is only complicated as result is not good,
> here's a patch to remove run cleanup chain. OK?

This needs a ChangeLog entry.  :)