From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix double free on error while inserting the breakpoint
Date: Thu, 23 Apr 2009 21:25:00 -0000 [thread overview]
Message-ID: <m3iqkvqcz7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090423203619.GA31736@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu\, 23 Apr 2009 22\:36\:19 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Tom> I like this but I am unsure whether it is ok to move the call to
Tom> update_global_location_list past the call to mention.
Jan> As in this case the breakpoint is pending and thus it was created by
Jan> set_raw_breakpoint_without_location and so update_global_location_list is
Jan> a nop for it. So I do not think it is a problem to move it.
Ok, that is convincing :)
Jan> 2009-04-23 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix double free on error inserting the breakpoint instruction.
Jan> * breakpoint.c (create_breakpoints): Move the
Jan> update_global_location_list call to ...
Jan> (break_command_really): ... here together with the second local call
Jan> both unified after all the cleanups.
Looks good to me, please check it in.
Thanks.
Tom
next prev parent reply other threads:[~2009-04-23 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 3:35 Jan Kratochvil
2009-04-22 23:11 ` Tom Tromey
2009-04-23 20:36 ` Jan Kratochvil
2009-04-23 21:25 ` Tom Tromey [this message]
2009-04-23 22:40 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iqkvqcz7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox