Re: [patch] Fix double free on error while inserting the breakpoint

Tom Tromey
2009-04-23T21:25:48Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> I like this but I am unsure whether it is ok to move the call to
Tom> update_global_location_list past the call to mention.

Jan> As in this case the breakpoint is pending and thus it was created by
Jan> set_raw_breakpoint_without_location and so update_global_location_list is
Jan> a nop for it. So I do not think it is a problem to move it.

Ok, that is convincing :)

Jan> 2009-04-23 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix double free on error inserting the breakpoint instruction.
Jan> * breakpoint.c (create_breakpoints): Move the
Jan> update_global_location_list call to ...
Jan> (break_command_really): ... here together with the second local call
Jan> both unified after all the cleanups.

Looks good to me, please check it in.
Thanks.

Tom