Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [01/15] Introduce get_current_arch () function
Date: Tue, 09 Jun 2009 17:04:00 -0000	[thread overview]
Message-ID: <m3iqj5l4on.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200906091514.n59FElgC026768@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Tue\, 9 Jun 2009 17\:14\:47 +0200 \(CEST\)")

>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich>  printf_command (char *arg, int from_tty)
Ulrich>  {
Ulrich> +  struct gdbarch *gdbarch = get_current_arch ();

I think that perhaps the printf command should use the arch from the
values it is trying to print.

Ulrich>  	      struct type *wctype = lookup_typename (current_language,
Ulrich> -						     current_gdbarch,
Ulrich> +						     gdbarch,
Ulrich>  						     "wchar_t", NULL, 0);

E.g., here it could use the architecture from val_args[i].

The benefit here would be that you could print out two wide strings,
each from a different architecture, using a single printf.  This seems
like a reasonable thing to want to do.

Tom


  reply	other threads:[~2009-06-09 17:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 15:15 Ulrich Weigand
2009-06-09 17:04 ` Tom Tromey [this message]
2009-06-10 15:36   ` Ulrich Weigand
2009-06-10 16:40     ` Tom Tromey
2009-06-10 18:14       ` Ulrich Weigand
2009-07-02 17:04         ` Ulrich Weigand
2009-06-10 16:49     ` Pedro Alves
2009-06-10 18:27       ` Ulrich Weigand
2009-06-10 19:23         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3iqj5l4on.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox