Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [Patch, trivial] Fix PR 11110
@ 2009-12-23 17:31 Dmitry Gorbachev
  2009-12-23 23:19 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gorbachev @ 2009-12-23 17:31 UTC (permalink / raw)
  To: gdb-patches

This patch fixes a duplicate definition of deprecated_trace_find_hook
and deprecated_trace_start_stop_hook.


2009-12-23  Dmitry Gorbachev  <d.g.gorbachev@gmail.com>

	PR gdb/11110
	* tracepoint.h (deprecated_trace_find_hook)
	(deprecated_trace_start_stop_hook): Declare extern.
	* tracepoint.c (deprecated_trace_find_hook)
	(deprecated_trace_start_stop_hook): Define.

--- gdb/tracepoint.c
+++ gdb/tracepoint.c
@@ -69,6 +69,10 @@
    large.  (400 - 31)/2 == 184 */
 #define MAX_AGENT_EXPR_LEN	184

+/* A hook used to notify the UI of tracepoint operations.  */
+
+void (*deprecated_trace_find_hook) (char *arg, int from_tty);
+void (*deprecated_trace_start_stop_hook) (int start, int from_tty);

 extern void (*deprecated_readline_begin_hook) (char *, ...);
 extern char *(*deprecated_readline_hook) (char *);
--- gdb/tracepoint.h
+++ gdb/tracepoint.h
@@ -39,8 +39,8 @@

 /* A hook used to notify the UI of tracepoint operations.  */

-void (*deprecated_trace_find_hook) (char *arg, int from_tty);
-void (*deprecated_trace_start_stop_hook) (int start, int from_tty);
+extern void (*deprecated_trace_find_hook) (char *arg, int from_tty);
+extern void (*deprecated_trace_start_stop_hook) (int start, int from_tty);

 int get_traceframe_number (void);
 void free_actions (struct breakpoint *);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch, trivial] Fix PR 11110
  2009-12-23 17:31 [Patch, trivial] Fix PR 11110 Dmitry Gorbachev
@ 2009-12-23 23:19 ` Tom Tromey
  2009-12-24  3:46   ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2009-12-23 23:19 UTC (permalink / raw)
  To: Dmitry Gorbachev; +Cc: gdb-patches

>>>>> "Dmitry" == Dmitry Gorbachev <gorbachev@reactos.org> writes:

Dmitry> This patch fixes a duplicate definition of deprecated_trace_find_hook
Dmitry> and deprecated_trace_start_stop_hook.

Looks good to me.  I'm checking it in.

This is below the size requiring a copyright assignment.  If you plan to
do more hacking on gdb, let me know and I can get you started on the
assignment process.  (Though I may not reply until January... be sure to
ping if you don't hear back after the holidays.)

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch, trivial] Fix PR 11110
  2009-12-23 23:19 ` Tom Tromey
@ 2009-12-24  3:46   ` Joel Brobecker
  0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2009-12-24  3:46 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Dmitry Gorbachev, gdb-patches

> This is below the size requiring a copyright assignment.  If you plan to
> do more hacking on gdb, let me know and I can get you started on the
> assignment process.  (Though I may not reply until January... be sure to
> ping if you don't hear back after the holidays.)

I can also help getting you started.

-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-12-24  3:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-23 17:31 [Patch, trivial] Fix PR 11110 Dmitry Gorbachev
2009-12-23 23:19 ` Tom Tromey
2009-12-24  3:46   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox