From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on stale addrinfo->sectindex
Date: Fri, 19 Feb 2010 03:01:00 -0000 [thread overview]
Message-ID: <m3iq9uapzi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100218092203.GA31309@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 18 Feb 2010 10:22:03 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Curiously it is not reproducible for me on FSF GDB HEAD but it is
Jan> reproducible on gdb-7.0.50.20100203-15.fc13.
Yes, odd.
Jan> /* This is the index used by BFD. */
Jan> - addrs->other[i].sectindex = sect->index;
I think you ought to move this comment as well.
It appears to just be hanging at the end of a block after the patch.
This is ok with that change. Thanks.
Tom
next prev parent reply other threads:[~2010-02-19 3:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 9:22 Jan Kratochvil
2010-02-19 3:01 ` Tom Tromey [this message]
2010-02-19 6:22 ` Jan Kratochvil
2010-02-19 13:16 ` Joel Brobecker
2010-02-19 14:07 ` Jan Kratochvil
2010-02-19 3:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iq9uapzi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox