From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70315-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4659 invoked by alias); 19 Feb 2010 03:01:16 -0000
Received: (qmail 4342 invoked by uid 22791); 19 Feb 2010 03:01:15 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 03:01:09 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1J318im016324 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Thu, 18 Feb 2010 22:01:08 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1J3170V010733; 	Thu, 18 Feb 2010 22:01:07 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1J316wI005835; 	Thu, 18 Feb 2010 22:01:06 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 290C2378212; Thu, 18 Feb 2010 20:01:06 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on stale addrinfo->sectindex
References: <20100218092203.GA31309@host0.dyn.jankratochvil.net>
Reply-To: tromey@redhat.com
Date: Fri, 19 Feb 2010 03:01:00 -0000
In-Reply-To: <20100218092203.GA31309@host0.dyn.jankratochvil.net> (Jan 	Kratochvil's message of "Thu, 18 Feb 2010 10:22:03 +0100")
Message-ID: <m3iq9uapzi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00474.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Curiously it is not reproducible for me on FSF GDB HEAD but it is
Jan> reproducible on gdb-7.0.50.20100203-15.fc13.

Yes, odd.

Jan>  	      /* This is the index used by BFD. */
Jan> -	      addrs->other[i].sectindex = sect->index;

I think you ought to move this comment as well.
It appears to just be hanging at the end of a block after the patch.

This is ok with that change.  Thanks.

Tom