From: Jim Blandy <jimb@codesourcery.com>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [5/6] Remove macro CANNOT_FETCH / STORE_REGISTERS
Date: Wed, 30 May 2007 21:23:00 -0000 [thread overview]
Message-ID: <m3hcpu57kq.fsf@codesourcery.com> (raw)
In-Reply-To: <465BD44E.3060103@de.ibm.com> (Markus Deuling's message of "Tue, 29 May 2007 09:20:46 +0200")
Markus Deuling <deuling@de.ibm.com> writes:
> ChangeLog:
>
> * gdbarch.sh (CANNOT_FETCH_REGISTER): Replace by
> gdbarch_cannot_fetch_register.
> * alpha-nat.c (fetch_osf_core_registers): Likewise.
> * hppa-linux-nat.c (fetch_register): Likewise.
> * inf-ptrace.c (inf_ptrace_fetch_register): Likewise.
> * m68klinux-nat.c (fetch_register): Likewise.
> * mipsnbsd-tdep.c (mipsnbsd_supply_reg,mipsnbsd_supply_fpreg): Likewise:
> * gdbarch.sh (CANNOT_STORE_REGISTER): Replace by
> gdbarch_cannot_store_register.
> * hppa-linux-nat.c (store_register): Likewise.
> * inf-ptrace.c (inf_ptrace_store_register): Likewise.
> * regcache.c (regcache_raw_write): Likewise.
> * m68klinux-nat.c (store_register): Likewise.
> * mipsnbsd-tdep.c (mipsnbsd_fill_reg, mipsnbsd_fill_fpreg): Likewise.
> * gdbarch.c, gdbarch.h: Regenerate.
>
>
> Is this ok to commit?
Yes, once the copyright assignment issues are sorted out, and the
minor issue noted below is fixed.
> diff -urN src/gdb/inf-ptrace.c dev/gdb/inf-ptrace.c
> --- src/gdb/inf-ptrace.c 2007-05-11 14:04:57.000000000 +0200
> +++ dev/gdb/inf-ptrace.c 2007-05-18 12:41:38.000000000 +0200
> @@ -626,7 +626,8 @@
>
> /* This isn't really an address, but ptrace thinks of it as one. */
> addr = inf_ptrace_register_u_offset (current_gdbarch, regnum, 0);
> - if (addr == (CORE_ADDR)-1 || CANNOT_FETCH_REGISTER (regnum))
> + if (addr == (CORE_ADDR)-1
> + || gdbarch_cannot_fetch_register (current_gdbarch ,regnum))
The comma should come immediately after current_gdbarch.
next prev parent reply other threads:[~2007-05-30 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 7:22 Markus Deuling
2007-05-30 21:23 ` Jim Blandy [this message]
2007-05-31 11:09 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hcpu57kq.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox