From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49104-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28585 invoked by alias); 30 May 2007 21:23:54 -0000
Received: (qmail 28575 invoked by uid 22791); 30 May 2007 21:23:53 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 May 2007 21:23:51 +0000
Received: (qmail 27550 invoked from network); 30 May 2007 21:23:50 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 30 May 2007 21:23:50 -0000
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, 	  Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [5/6] Remove macro CANNOT_FETCH / STORE_REGISTERS
References: <465BD44E.3060103@de.ibm.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 30 May 2007 21:23:00 -0000
In-Reply-To: <465BD44E.3060103@de.ibm.com> (Markus Deuling's message of "Tue, 29 May 2007 09:20:46 +0200")
Message-ID: <m3hcpu57kq.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-05/txt/msg00427.txt.bz2


Markus Deuling <deuling@de.ibm.com> writes:
> ChangeLog:
>
> 	* gdbarch.sh (CANNOT_FETCH_REGISTER): Replace by
> 	gdbarch_cannot_fetch_register.
> 	* alpha-nat.c (fetch_osf_core_registers): Likewise.
> 	* hppa-linux-nat.c (fetch_register): Likewise.
> 	* inf-ptrace.c (inf_ptrace_fetch_register): Likewise.
> 	* m68klinux-nat.c (fetch_register): Likewise.
> 	* mipsnbsd-tdep.c (mipsnbsd_supply_reg,mipsnbsd_supply_fpreg): Likewise:
> 	* gdbarch.sh (CANNOT_STORE_REGISTER): Replace by
> gdbarch_cannot_store_register.
> 	* hppa-linux-nat.c (store_register): Likewise.
> 	* inf-ptrace.c (inf_ptrace_store_register): Likewise.
> 	* regcache.c (regcache_raw_write): Likewise.
> 	* m68klinux-nat.c (store_register): Likewise.
> 	* mipsnbsd-tdep.c (mipsnbsd_fill_reg, mipsnbsd_fill_fpreg): Likewise.
> 	* gdbarch.c, gdbarch.h: Regenerate.
>
>
> Is this ok to commit?

Yes, once the copyright assignment issues are sorted out, and the
minor issue noted below is fixed.

> diff -urN src/gdb/inf-ptrace.c dev/gdb/inf-ptrace.c
> --- src/gdb/inf-ptrace.c	2007-05-11 14:04:57.000000000 +0200
> +++ dev/gdb/inf-ptrace.c	2007-05-18 12:41:38.000000000 +0200
> @@ -626,7 +626,8 @@
>  
>    /* This isn't really an address, but ptrace thinks of it as one.  */
>    addr = inf_ptrace_register_u_offset (current_gdbarch, regnum, 0);
> -  if (addr == (CORE_ADDR)-1 || CANNOT_FETCH_REGISTER (regnum))
> +  if (addr == (CORE_ADDR)-1 
> +      || gdbarch_cannot_fetch_register (current_gdbarch ,regnum))

The comma should come immediately after current_gdbarch.