Re: Iconv / Solaris

[Tom Tromey <tromey@redhat.com>]

>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

Daniel> On Thu, Aug 27, 2009 at 02:30:30PM -0600, Tom Tromey wrote:
>> The initial problem here is that iconv will not accept "wchar_t" as an
>> encoding on this platform.  I see we only have one AC_TRY_RUN in gdb
>> ... am I right in assuming that these are not ok?

Daniel> They are not OK.  Please don't add another if you can avoid it.  I
Daniel> think the one that's there is for long long printf?  I used to have
Daniel> to override the cache variable... haven't checked lately.

Oops, I read your notes out-of-order.

Ok, no new AC_TRY_RUN.

The existing one is some obscure old Linux thing:

  dnl For Linux/i386, glibc 2.1.3 was released with a bogus
  dnl prfpregset_t type (it's a typedef for the pointer to a struct
  dnl instead of the struct itself).  We detect this here, and work
  dnl around it in gdb_proc_service.h.

>> If they are not ok, I think we can just add a new setting to
>> configure.host.  This is simpler to implement.

Daniel> I'm not sure how to do this without hardcoding it by platform.  If the
Daniel> user has external libiconv, do we still want a change?

What we want is to skip case #1 in gdb_wchar.h (the full support case)
and let configure choose between case #2 (iconv only) and case #3
(nothing) depending on whether iconv was found.

I can write a patch tomorrow.

Tom