From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15872 invoked by alias); 28 Aug 2009 01:01:33 -0000 Received: (qmail 15698 invoked by uid 22791); 28 Aug 2009 01:01:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 01:01:26 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7S11Ow5024228 for ; Thu, 27 Aug 2009 21:01:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7S11Nvh016884; Thu, 27 Aug 2009 21:01:23 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7S11M8o006111; Thu, 27 Aug 2009 21:01:22 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 143363782A9; Thu, 27 Aug 2009 19:01:22 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: Iconv / Solaris References: <20090827020639.GA13935@caradoc.them.org> <20090827170851.GA25905@caradoc.them.org> <20090827203609.GA13388@caradoc.them.org> Reply-To: tromey@redhat.com Date: Fri, 28 Aug 2009 01:24:00 -0000 In-Reply-To: <20090827203609.GA13388@caradoc.them.org> (Daniel Jacobowitz's message of "Thu, 27 Aug 2009 16:36:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00501.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Daniel> On Thu, Aug 27, 2009 at 02:30:30PM -0600, Tom Tromey wrote: >> The initial problem here is that iconv will not accept "wchar_t" as an >> encoding on this platform. I see we only have one AC_TRY_RUN in gdb >> ... am I right in assuming that these are not ok? Daniel> They are not OK. Please don't add another if you can avoid it. I Daniel> think the one that's there is for long long printf? I used to have Daniel> to override the cache variable... haven't checked lately. Oops, I read your notes out-of-order. Ok, no new AC_TRY_RUN. The existing one is some obscure old Linux thing: dnl For Linux/i386, glibc 2.1.3 was released with a bogus dnl prfpregset_t type (it's a typedef for the pointer to a struct dnl instead of the struct itself). We detect this here, and work dnl around it in gdb_proc_service.h. >> If they are not ok, I think we can just add a new setting to >> configure.host. This is simpler to implement. Daniel> I'm not sure how to do this without hardcoding it by platform. If the Daniel> user has external libiconv, do we still want a change? What we want is to skip case #1 in gdb_wchar.h (the full support case) and let configure choose between case #2 (iconv only) and case #3 (nothing) depending on whether iconv was found. I can write a patch tomorrow. Tom