From: Tom Tromey <tromey@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Another obstack patch.
Date: Thu, 22 Apr 2010 19:04:00 -0000 [thread overview]
Message-ID: <m3hbn348dt.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BD057DF.7070904@redhat.com> (Chris Moller's message of "Thu, 22 Apr 2010 10:06:23 -0400")
>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:
Chris> static void cp_print_value (struct type *, struct type *, const gdb_byte *,
Chris> int, CORE_ADDR, struct ui_file *, int,
Chris> - const struct value_print_options *, struct type **);
Chris> + const struct value_print_options *,
Chris> + struct type **);
Don't mix reformatting and semantic changes.
Chris> + if (obstack_final_size > stat_array_obstack_initial_size) {
Wrong brace placement.
Ok with those changes.
Tom
next prev parent reply other threads:[~2010-04-22 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 14:06 Chris Moller
2010-04-22 19:04 ` Tom Tromey [this message]
2010-04-22 20:13 ` Chris Moller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbn348dt.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox