From: Tom Tromey <tromey@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR testsuite/12040: GDB Fortran tests use g77 instead of gfortran
Date: Tue, 28 Jun 2011 19:35:00 -0000 [thread overview]
Message-ID: <m3hb797nqu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100920135856.GA27953@intel.com> (H. J. Lu's message of "Mon, 20 Sep 2010 06:58:56 -0700")
>>>>> "HJ" == H J Lu <hongjiu.lu@intel.com> writes:
HJ> This isn't a proper fix since it depends on we load lib/ada.exp before
HJ> any Fortran tests. I think ada.exp is the wrong place to provide
HJ> GDB functions. It should be placed in something like gdb-support.exp and
HJ> ada.exp/fortran.exp can just load it.
I'm sorry that it took so long for me to review this patch.
HJ> PR testsuite/12040
HJ> * lib/ada.exp (gdb_find_gfortran): New.
HJ> (gdb_default_target_compile): Use it.
I would like something like this to go in, but I don't think this will
have the desired effect, since ada.exp is not always loaded.
Instead I think these procs must be moved elsewhere so they are always
used.
I sent a patch to dejagnu to allow f90 today; so perhaps the result
could be based on that. I can do the work if you like, just let me
know.
Tom
next prev parent reply other threads:[~2011-06-28 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 18:24 H.J. Lu
2011-06-28 19:35 ` Tom Tromey [this message]
2011-06-28 19:56 ` H.J. Lu
2011-06-29 14:44 ` Tom Tromey
2011-06-29 14:51 ` H.J. Lu
2011-06-29 14:58 ` Tom Tromey
2011-06-29 17:50 ` Tom Tromey
2011-06-29 17:52 ` H.J. Lu
2011-06-29 18:26 ` Tom Tromey
2011-06-29 18:29 ` H.J. Lu
2011-06-30 13:29 ` Tom Tromey
2011-06-29 20:45 ` Jan Kratochvil
2011-06-29 20:49 ` Tom Tromey
2011-06-29 20:56 ` Jan Kratochvil
2011-06-29 16:10 ` Joel Brobecker
2011-06-29 17:35 ` Tom Tromey
2011-06-29 17:58 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb797nqu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox