From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1839 invoked by alias); 28 Jun 2011 19:35:55 -0000 Received: (qmail 1686 invoked by uid 22791); 28 Jun 2011 19:35:54 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 19:35:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5SJZdu3005277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Jun 2011 15:35:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5SJZdPL027191; Tue, 28 Jun 2011 15:35:39 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5SJZbtw024552; Tue, 28 Jun 2011 15:35:37 -0400 From: Tom Tromey To: "H.J. Lu" Cc: GDB Subject: Re: PATCH: PR testsuite/12040: GDB Fortran tests use g77 instead of gfortran References: <20100920135856.GA27953@intel.com> Date: Tue, 28 Jun 2011 19:35:00 -0000 In-Reply-To: <20100920135856.GA27953@intel.com> (H. J. Lu's message of "Mon, 20 Sep 2010 06:58:56 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00418.txt.bz2 >>>>> "HJ" == H J Lu writes: HJ> This isn't a proper fix since it depends on we load lib/ada.exp before HJ> any Fortran tests. I think ada.exp is the wrong place to provide HJ> GDB functions. It should be placed in something like gdb-support.exp and HJ> ada.exp/fortran.exp can just load it. I'm sorry that it took so long for me to review this patch. HJ> PR testsuite/12040 HJ> * lib/ada.exp (gdb_find_gfortran): New. HJ> (gdb_default_target_compile): Use it. I would like something like this to go in, but I don't think this will have the desired effect, since ada.exp is not always loaded. Instead I think these procs must be moved elsewhere so they are always used. I sent a patch to dejagnu to allow f90 today; so perhaps the result could be based on that. I can do the work if you like, just let me know. Tom