Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
	gdb-patches@sourceware.org,
	       Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [patch] testsuite: Fix mi-solib.exp without debuginfos  [Re: [3/3] RFC: fix PR mi/8444]
Date: Fri, 09 Dec 2011 21:26:00 -0000	[thread overview]
Message-ID: <m3hb19ea0e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111202011800.GA23680@host2.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 2 Dec 2011 02:18:00 +0100")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I have checked the result of mi_expect_stop is not used anywhere so it is
Jan> questionable what it should return.

Unfortunately, a Tcl proc returns its last computed value if there is no
explicit return.  So, this caused:

ERROR: tcl error sourcing ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp.
ERROR: missing operand at _@_
in expression "!_@_"
    (parsing expression "!")
    invoked from within
"if ![mi_run_to_main] then {
   fail "Cannot run to main, testcase aborted"
   return 0
}"
    (file "../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp" line 109)
    invoked from within
"source ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

Tom


  parent reply	other threads:[~2011-12-09 21:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 20:28 [3/3] RFC: fix PR mi/8444 Tom Tromey
2011-11-16 21:31 ` Pedro Alves
2011-11-17 16:41   ` Tom Tromey
2011-11-22 14:55     ` Pedro Alves
2011-11-22 21:22       ` Tom Tromey
2011-11-25 16:08         ` Ulrich Weigand
2011-12-02  1:18           ` [patch] testsuite: Fix mi-solib.exp without debuginfos [Re: [3/3] RFC: fix PR mi/8444] Jan Kratochvil
2011-12-02 16:17             ` Tom Tromey
2011-12-02 22:36               ` [commit] " Jan Kratochvil
2011-12-09 21:26             ` Tom Tromey [this message]
2011-12-09 21:54               ` Jan Kratochvil
2011-12-09 21:56                 ` Tom Tromey
2011-11-17  4:03 ` [3/3] RFC: fix PR mi/8444 Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hb19ea0e.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pedro@codesourcery.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox