From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85995-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27583 invoked by alias); 9 Dec 2011 21:00:26 -0000
Received: (qmail 27572 invoked by uid 22791); 9 Dec 2011 21:00:25 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 21:00:10 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB9L05jR002136	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 9 Dec 2011 16:00:05 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pB9L04aZ010143;	Fri, 9 Dec 2011 16:00:04 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pB9L02aD028669;	Fri, 9 Dec 2011 16:00:02 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org,        Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [patch] testsuite: Fix mi-solib.exp without debuginfos  [Re: [3/3] RFC: fix PR mi/8444]
References: <m31usz3la9.fsf@fleche.redhat.com>	<201111251608.pAPG81oE002175@d06av02.portsmouth.uk.ibm.com>	<20111202011800.GA23680@host2.jankratochvil.net>
Date: Fri, 09 Dec 2011 21:26:00 -0000
In-Reply-To: <20111202011800.GA23680@host2.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 2 Dec 2011 02:18:00 +0100")
Message-ID: <m3hb19ea0e.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00314.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I have checked the result of mi_expect_stop is not used anywhere so it is
Jan> questionable what it should return.

Unfortunately, a Tcl proc returns its last computed value if there is no
explicit return.  So, this caused:

ERROR: tcl error sourcing ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp.
ERROR: missing operand at _@_
in expression "!_@_"
    (parsing expression "!")
    invoked from within
"if ![mi_run_to_main] then {
   fail "Cannot run to main, testcase aborted"
   return 0
}"
    (file "../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp" line 109)
    invoked from within
"source ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ../../../archer/gdb/testsuite/gdb.ada/mi_catch_ex.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

Tom