From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] append_composite_type_field_aligned
Date: Wed, 22 Jun 2011 19:55:00 -0000 [thread overview]
Message-ID: <m3fwn14p6p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4DF0E83C.8010600@broadcom.com> (Andrew Burgess's message of "Thu, 9 Jun 2011 16:35:24 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
I'm sorry about the delay on this.
Pinging was the right thing to do -- thank you.
Andrew> 2011-06-09 Andrew Burgess <aburgess@broadcom.com>
Andrew> * gdbtypes.c (append_composite_type_field_aligned): Fix
Andrew> calculation of bit position based on alignment.
Ok with one nit..
Andrew> + int left;
Andrew> + alignment *= TARGET_CHAR_BIT;
Blank line between declarations and code.
Tom
next prev parent reply other threads:[~2011-06-22 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 15:35 Andrew Burgess
2011-06-21 9:47 ` Andrew Burgess
2011-06-21 12:54 ` Yao Qi
2011-06-22 19:55 ` Tom Tromey [this message]
2011-06-23 9:53 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwn14p6p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox