From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81730-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1833 invoked by alias); 22 Jun 2011 19:55:00 -0000
Received: (qmail 1820 invoked by uid 22791); 22 Jun 2011 19:54:59 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 19:54:41 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5MJseG9007824	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 22 Jun 2011 15:54:40 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5MJse7N007068;	Wed, 22 Jun 2011 15:54:40 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5MJscHC029893;	Wed, 22 Jun 2011 15:54:39 -0400
From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] append_composite_type_field_aligned
References: <4DF0E83C.8010600@broadcom.com>
Date: Wed, 22 Jun 2011 19:55:00 -0000
In-Reply-To: <4DF0E83C.8010600@broadcom.com> (Andrew Burgess's message of	"Thu, 9 Jun 2011 16:35:24 +0100")
Message-ID: <m3fwn14p6p.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-06/txt/msg00328.txt.bz2

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

I'm sorry about the delay on this.

Pinging was the right thing to do -- thank you.

Andrew> 2011-06-09  Andrew Burgess  <aburgess@broadcom.com>
Andrew> 	* gdbtypes.c (append_composite_type_field_aligned): Fix
Andrew>           calculation of bit position based on alignment.

Ok with one nit..

Andrew> +	      int left;
Andrew> +	      alignment *= TARGET_CHAR_BIT;

Blank line between declarations and code.

Tom