Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gcc-patches@gcc.gnu.org, binutils@sourceware.org,
	        gdb-patches@sourceware.org
Subject: Re: [patch] libiberty: demangle_component for `global 	{constructors,destructors} keyed to'
Date: Tue, 14 Jul 2009 14:58:00 -0000	[thread overview]
Message-ID: <m3eisjcp0m.fsf@google.com> (raw)
In-Reply-To: <20090711201940.GA7327@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat\, 11 Jul 2009 22\:19\:40 +0200")

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> include/
> 2009-07-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
> 	* demangle.h
> 	(enum demangle_component_type <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(enum demangle_component_type <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS>):
> 	New.
>
> libiberty/
> 2009-07-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
> 	* cp-demangle.c (d_print_comp <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(d_print_comp <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS): New.
> 	(d_make_comp <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(d_make_comp <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS): New.
> 	(d_demangle_callback): The variable type is now declared as enum.
> 	Replace parser of _GLOBAL_ symbols by a d_make_comp call.
> +	dc = d_make_comp (&di, type == DCT_GLOBAL_CTORS
> +		               ? DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS
> +			       : DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS,
> +			  d_make_name (&di, d_str (&di), strlen (d_str (&di))),
> +			  NULL);

Format as

	dc = d_make_comp (&di,
			  (type == DCT_GLOBAL_CTORS
		           ? DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS
			   : DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS),
			  d_make_name (&di, d_str (&di), strlen (d_str (&di))),
			  NULL);

This is OK with that change.

I assume you ran the libiberty testsuite.

Thanks.

Ian


  reply	other threads:[~2009-07-14 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11 23:29 Jan Kratochvil
2009-07-14 14:58 ` Ian Lance Taylor [this message]
2009-07-18 13:50   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3eisjcp0m.fsf@google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox