From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65398-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27175 invoked by alias); 14 Jul 2009 14:34:29 -0000
Received: (qmail 27140 invoked by uid 22791); 14 Jul 2009 14:34:28 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Jul 2009 14:34:20 +0000
Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) 	by smtp-out.google.com with ESMTP id n6EEYGLM025679; 	Tue, 14 Jul 2009 07:34:16 -0700
Received: from ewy1 (ewy1.prod.google.com [10.241.103.1]) 	by spaceape14.eur.corp.google.com with ESMTP id n6EEYDQf001001; 	Tue, 14 Jul 2009 07:34:13 -0700
Received: by ewy1 with SMTP id 1so452951ewy.2         for <multiple recipients>; Tue, 14 Jul 2009 07:34:12 -0700 (PDT)
Received: by 10.210.110.5 with SMTP id i5mr6662677ebc.80.1247582052886;         Tue, 14 Jul 2009 07:34:12 -0700 (PDT)
Received: from localhost.localdomain.google.com ([67.218.106.36])         by mx.google.com with ESMTPS id 7sm4505460eyb.45.2009.07.14.07.34.07         (version=TLSv1/SSLv3 cipher=RC4-MD5);         Tue, 14 Jul 2009 07:34:11 -0700 (PDT)
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gcc-patches@gcc.gnu.org, binutils@sourceware.org,         gdb-patches@sourceware.org
Subject: Re: [patch] libiberty: demangle_component for `global 	{constructors,destructors} keyed to'
References: <20090711201940.GA7327@host0.dyn.jankratochvil.net>
From: Ian Lance Taylor <iant@google.com>
Date: Tue, 14 Jul 2009 14:58:00 -0000
In-Reply-To: <20090711201940.GA7327@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat\, 11 Jul 2009 22\:19\:40 +0200")
Message-ID: <m3eisjcp0m.fsf@google.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-System-Of-Record: true
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00377.txt.bz2

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> include/
> 2009-07-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
> 	* demangle.h
> 	(enum demangle_component_type <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(enum demangle_component_type <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS>):
> 	New.
>
> libiberty/
> 2009-07-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
> 	* cp-demangle.c (d_print_comp <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(d_print_comp <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS): New.
> 	(d_make_comp <DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS>)
> 	(d_make_comp <DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS): New.
> 	(d_demangle_callback): The variable type is now declared as enum.
> 	Replace parser of _GLOBAL_ symbols by a d_make_comp call.
> +	dc = d_make_comp (&di, type == DCT_GLOBAL_CTORS
> +		               ? DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS
> +			       : DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS,
> +			  d_make_name (&di, d_str (&di), strlen (d_str (&di))),
> +			  NULL);

Format as

	dc = d_make_comp (&di,
			  (type == DCT_GLOBAL_CTORS
		           ? DEMANGLE_COMPONENT_GLOBAL_CONSTRUCTORS
			   : DEMANGLE_COMPONENT_GLOBAL_DESTRUCTORS),
			  d_make_name (&di, d_str (&di), strlen (d_str (&di))),
			  NULL);

This is OK with that change.

I assume you ran the libiberty testsuite.

Thanks.

Ian