From: Tom Tromey <tromey@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [RFC][patch] Tweak output of -var-info-path-expression
Date: Sat, 11 Sep 2010 17:28:00 -0000 [thread overview]
Message-ID: <m3eid1jlvb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC5718DBD843@EUSAACMS0703.eamcs.ericsson.se> (Marc Khouzam's message of "Thu, 9 Sep 2010 15:54:45 -0400")
>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:
Marc> Bug 11912 (http://sourceware.org/bugzilla/show_bug.cgi?id=11912)
Marc> is causing a syntax error when casting to a class in
Marc> certain cases. (see small session below for example)
Marc> I'm suggesting to add the workaround to the output of
Marc> -var-info-path-expression when it casts.
Marc> It would be nicer to fix the parser problem but that
Marc> seems much more complicated (at least for me).
I hate to work around other bugs, but in this case it seems practical.
Marc> I've attached a patch in hopes of comments but I have to
Marc> admit that the implications of this change are not clear to me.
Marc> Thanks for any feedback
I think a regression test in the test suite would be valuable.
Marc> 2010-09-08 Marc Khouzam <marc.khouzam@ericsson.com>
Marc> * varobj.c (cplus_describe_child): Add `class'
Marc> keyword to avoid confusion with constructor name.
I think the patch itself is ok, but I would like to wait a little while
to see if other maintainers, particularly Volodya, have any objections.
Tom
prev parent reply other threads:[~2010-09-10 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 20:01 Marc Khouzam
2010-09-11 17:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eid1jlvb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox