From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25895 invoked by alias); 10 Sep 2010 22:05:07 -0000 Received: (qmail 25886 invoked by uid 22791); 10 Sep 2010 22:05:06 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 22:05:02 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8AM4wwF009431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Sep 2010 18:04:59 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8AM4wjA018669; Fri, 10 Sep 2010 18:04:58 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8AM4vwI024545; Fri, 10 Sep 2010 18:04:57 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1481E3792BD; Fri, 10 Sep 2010 16:04:56 -0600 (MDT) From: Tom Tromey To: Marc Khouzam Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [RFC][patch] Tweak output of -var-info-path-expression References: Date: Sat, 11 Sep 2010 17:28:00 -0000 In-Reply-To: (Marc Khouzam's message of "Thu, 9 Sep 2010 15:54:45 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00237.txt.bz2 >>>>> "Marc" == Marc Khouzam writes: Marc> Bug 11912 (http://sourceware.org/bugzilla/show_bug.cgi?id=11912) Marc> is causing a syntax error when casting to a class in Marc> certain cases. (see small session below for example) Marc> I'm suggesting to add the workaround to the output of Marc> -var-info-path-expression when it casts. Marc> It would be nicer to fix the parser problem but that Marc> seems much more complicated (at least for me). I hate to work around other bugs, but in this case it seems practical. Marc> I've attached a patch in hopes of comments but I have to Marc> admit that the implications of this change are not clear to me. Marc> Thanks for any feedback I think a regression test in the test suite would be valuable. Marc> 2010-09-08 Marc Khouzam Marc> * varobj.c (cplus_describe_child): Add `class' Marc> keyword to avoid confusion with constructor name. I think the patch itself is ok, but I would like to wait a little while to see if other maintainers, particularly Volodya, have any objections. Tom