[patch, testsuite] store memory address in unsigned type

[patch, testsuite] store memory address in unsigned type

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

In gdb.trace/tfile.c:add_memory_block(), we store memory address in
long, and assign (extend) to long long.  It is not correct if the MSB of
address is 1, and signed extension will fill the upper 32-bit of long
long with 1, which is not what we want here.

This patch is to use unsigned type.  OK?

-- 
Yao (齐尧)

[-- Attachment #2: unsigned_address.patch --]
[-- Type: text/x-patch, Size: 803 bytes --]

gdb/testsuite/
2011-05-13  Yao Qi  <yao@codesourcery.com>

	* gdb.trace/tfile.c (add_memory_block): Store address in unsigned
	type.

Index: testsuite/gdb.trace/tfile.c
===================================================================
--- testsuite/gdb.trace/tfile.c	(revision 325446)
+++ testsuite/gdb.trace/tfile.c	(working copy)
@@ -49,13 +49,13 @@
 add_memory_block (char *addr, int size)
 {
   short short_x;
-  long long ll_x;
+  unsigned long long ll_x;
 
   *((char *) trptr) = 'M';
   trptr += 1;
-  ll_x = (long) addr;
-  memcpy (trptr, &ll_x, sizeof (long long));
-  trptr += sizeof (long long);
+  ll_x = (unsigned long) addr;
+  memcpy (trptr, &ll_x, sizeof (unsigned long long));
+  trptr += sizeof (unsigned long long);
   short_x = size;
   memcpy (trptr, &short_x, 2);
   trptr += 2;

Re: [patch, testsuite] store memory address in unsigned type

[Tom Tromey]

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2011-05-13  Yao Qi  <yao@codesourcery.com>
Yao> 	* gdb.trace/tfile.c (add_memory_block): Store address in unsigned
Yao> 	type.

Looks reasonable to me.  Ok.

Tom

[committed] [patch, testsuite] store memory address in unsigned type

[Yao Qi]

On 05/13/2011 11:46 PM, Tom Tromey wrote:
> Yao> 2011-05-13  Yao Qi  <yao@codesourcery.com>
> Yao> 	* gdb.trace/tfile.c (add_memory_block): Store address in unsigned
> Yao> 	type.
> 
> Looks reasonable to me.  Ok.

Committed.
http://sourceware.org/ml/gdb-cvs/2011-05/msg00107.html

-- 
Yao (齐尧)